Modifying State of a Component Directly

Evan Hicks

—July 12, 2022

The Problem

The state of a component is managed internally by React. Updating the state of a component directly can have unintended consequences that can be difficult to debug.

Click to Copy

class Counter extends Component {
    constructor(props) {
        super(props)
        this.state = {
            counter: 0,
        }
    }

    increment() {
        this.state.counter = this.state.counter + this.props.increment
    }
}

If the state is updated directly as in the example above, the component will not rerender since the state is compared shallowly. Additionally, the update may be lost if there are other state changes queued asynchronously using setState.

Another common problem is using the current state/props to update the new state.

Click to Copy

class Counter extends Component {
    constructor(props) {
        super(props)
        this.state = {
            counter: 0,
        }
    }

    increment() {
        this.setState({
            counter: this.state.counter + this.props.increment
        })
    }
}

This will potentially cause issues due to a potential race condition between other state/prop changes and this particular state update. What happens if the props and/or state change before this state update happens?

The Solution

The solution for the first example is to always use the setState function to ensure state changes are properly queued. For the second problem, React provides a different version of setState that takes a function instead of an object.

Click to Copy

class Counter extends Component {
    constructor(props) {
        super(props)
        this.state = {
            counter: 0,
        }
    }

    increment() {
        this.setState((prevState, props) => ({
            counter: prevState.counter + props.increment
        })
    }
}

This will ensure that the state change happens with the correct version of the previous state and props.

Platform

Languages & Frameworks

Why Sentry?

Modifying State of a Component Directly

The Problem

The Solution

Further Reading

Modifying State of a Component Directly

The Solution

Further Reading

A peek at your privacy

Who we collect PII from

PII we may collect about you

How we use your PII

Third parties who receive your PII

We use cookies (but not for advertising)

Know your rights